Fix build regression with updated Seabios #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for the gnarly hack we were using to get a custom resolution.
samueldr
force-pushed
the
fix/seabios-regression
branch
from
36400b0
to
fd66311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Hydra:
A mixture of updates broke our previous hack, but that same mixture of updates allows us to rely on the relatively new EDID support in both QEMU and the Kernel.
The best advantage this gives us is complete control over the resolution with the screen width/height options, as they now set the resolution unconditionally instead of relying on a list of known modes and a selected mode.