Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: 8.55.0.141 -> 8.56.0.103 #85854

Merged
merged 1 commit into from Apr 25, 2020
Merged

skypeforlinux: 8.55.0.141 -> 8.56.0.103 #85854

merged 1 commit into from Apr 25, 2020

Conversation

emmanuelrosa
Copy link
Contributor

Motivation for this change

Update skypeforlinux. Closes #85724

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from PanAeon and jraygauthier April 23, 2020 11:06
@jonringer
Copy link
Contributor

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

also, you should be targeting release-20.03

@mmilata mmilata mentioned this pull request Apr 23, 2020
Merged
10 tasks
@bachp @emmanuelrosa
skypeforlinux: 8.56.0.103 -> 8.58.0.93
08630e5 
Cherry-picked 36c7dc2
Original commit merged in PR NixOS#83355
@emmanuelrosa emmanuelrosa changed the base branch from nixos-20.03 to release-20.03 April 24, 2020 06:00
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: lua 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 8.has: module (update) and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: lua 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python labels Apr 24, 2020
@worldofpeace worldofpeace merged commit 4786f8e into NixOS:release-20.03 Apr 25, 2020
@emmanuelrosa emmanuelrosa deleted the skype-dep-8.56 branch April 27, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanAeon PanAeon Awaiting requested review from PanAeon

@jraygauthier jraygauthier Awaiting requested review from jraygauthier

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emmanuelrosa @jonringer @worldofpeace @bachp