Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: Unbreak few, add me as a maintainer #90205

Merged
merged 3 commits into from
Jun 12, 2020
Merged

haskellPackages: Unbreak few, add me as a maintainer #90205

merged 3 commits into from
Jun 12, 2020
+9 −2

Conversation

sorki
Copy link
Member

@sorki sorki commented Jun 12, 2020

Motivation for this change

Unbreak of nix-narinfo and zre packages. Adding me as a maintainer for my own packages and nix-derivation lib.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

sorki added 2 commits June 12, 2020 21:11
@sorki
haskellPackages.nix-narinfo: unbreak
5aa45a5
@sorki
haskellPackages.zre: unbreak

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
dd1abef
@sorki sorki requested a review from cdepillabout as a code owner June 12, 2020 19:19
@sorki
haskellPackages: add me as maintainer for my packages
af6e0df 
and nix-derivation which I care about.
@peti peti merged this pull request into NixOS:haskell-updates Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sorki @peti