Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.14.0 -> 1.15.1 #90179

Merged
merged 1 commit into from Jun 17, 2020
Merged

matrix-synapse: 1.14.0 -> 1.15.1 #90179

merged 1 commit into from Jun 17, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 12, 2020 •
edited

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.15.0
https://github.com/matrix-org/synapse/releases/tag/v1.15.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 12, 2020
@ofborg ofborg bot requested review from fadenb, Ekleog, pacien and mguentner June 12, 2020 10:36
@mguentner
Copy link
Contributor

LGTM

@pacien
Copy link
Contributor

pacien commented Jun 15, 2020

Pinging @bachp, @corngood, @Ralith, @roblabla, @worldofpeace who are being removed from the modules and packages maintainer lists but not added to the newly created team.

@Ma27 Ma27 changed the title matrix-synapse: 1.14.0 -> 1.15.0 matrix-synapse: 1.14.0 -> 1.15.1 Jun 16, 2020
@Ma27 Ma27 requested review from Ekleog, fadenb and mguentner June 16, 2020 22:48
@Ma27
Copy link
Member Author

Ma27 commented Jun 16, 2020

As suggested by @pacien, the maintainer-team change is in its own PR in #90646 now.

@ofborg ofborg bot requested a review from Ralith June 16, 2020 22:50
bachp
bachp approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working

@Ma27 Ma27 merged commit 2a3ceb7 into NixOS:master Jun 17, 2020
@Ma27 Ma27 deleted the bump-matrix-synapse branch June 17, 2020 21:43
@Ma27
Copy link
Member Author

Ma27 commented Jun 17, 2020

Ported to stable as 73d7516.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@Ekleog Ekleog Ekleog approved these changes

@fadenb fadenb fadenb approved these changes

@pacien pacien pacien approved these changes

@mguentner mguentner Awaiting requested review from mguentner

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ma27 @mguentner @pacien @bachp @Ekleog @fadenb