Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gitlab auth token #3688

Closed
wants to merge 1 commit into from
Closed

add gitlab auth token #3688

wants to merge 1 commit into from

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Jun 12, 2020

This adds the possibility to set own headers in fetchers::downloadFile and fetchers::downloadTarball. which is needed for the access of private repos on gitlab.

@Kloenk
Copy link
Member Author

Kloenk commented Jun 13, 2020

This serves as a follow up to #3660 and #3662 which introduced the gitlab libfetcher

@Kloenk Kloenk mentioned this pull request Jun 13, 2020
Merged
@Kloenk
Copy link
Member Author

Kloenk commented Jun 13, 2020

Closing in favor of #3675.

@Kloenk Kloenk closed this Jun 13, 2020
@imalsogreg
Copy link
Contributor

@Kloenk was it spelled gitlabbAccessToken intentionally (with two bs)?

@Kloenk
Copy link
Member Author

Kloenk commented Jun 13, 2020

No, just me not being able to spell things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kloenk @imalsogreg