Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdk-pixbuf-xlib: fix the pkg-config file #90183

Closed
wants to merge 1 commit into from
Closed

gdk-pixbuf-xlib: fix the pkg-config file #90183

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 12, 2020

Motivation for this change

The pkg-config file gdk-pixbuf-xlib-2.0.pc contains the line:

Cflags:-I${includedir}/gdk-pixbuf-xlib-2.0

But the header files are installed at include/gdk-pixbuf-2.0. Notice the missing xlib in the directory name.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
gdk-pixbuf-xlib: fix the pkg-config file
f4f67e3 
The pkg-config file gdk-pixbuf-xlib-2.0.pc contains the line:

  Cflags:-I${includedir}/gdk-pixbuf-xlib-2.0

But the header files are installed at include/gdk-pixbuf-2.0. Notice
the missing xlib in the directory name.
@romildo
Copy link
Contributor Author

romildo commented Jun 12, 2020

Fixes #90168

@jtojnar
Copy link
Contributor

jtojnar commented Jun 12, 2020

This should already be fixed on master (5a416c0).

@romildo romildo closed this Jun 12, 2020
@romildo romildo deleted the fix.gdk-pixbuf-xlib branch June 12, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @jtojnar