Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title of the app before it loads #97

Merged
merged 2 commits into from Jun 12, 2020
Merged

Fix title of the app before it loads #97

merged 2 commits into from Jun 12, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Jun 12, 2020

and also improve on window titles for other pages

fixes #93

@github-actions
Copy link
Contributor

@garbas garbas merged commit 2daa4b0 into master Jun 12, 2020
@garbas garbas deleted the fix-93 branch June 12, 2020 10:20
@samueldr
Copy link
Member

One issue with adding Loading... to the non-js'd version of the page is that our entries in search results may show NixOS Search - Loading... depending how much JS the crawler executes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[review] Page title before loading the app is misleading
2 participants