Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.merlin: 3.3.4 -> 3.3.6 #90185

Merged
merged 1 commit into from Jun 13, 2020
Merged

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor Author

marsam commented Jun 12, 2020

@GrahamcOfBorg eval
@GrahamcOfBorg build ocamlPackages.merlin

@marsam marsam merged commit 7602241 into NixOS:master Jun 13, 2020
@marsam marsam deleted the update-merlin branch June 13, 2020 17:24
@vbgl
Copy link
Contributor

vbgl commented Jun 15, 2020

Duplicate of #90085

@vbgl vbgl marked this as a duplicate of #90085 Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants