Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk: 11.0.6 -> 11.0.7 #90234

Merged
merged 2 commits into from Jun 18, 2020
Merged

openjdk: 11.0.6 -> 11.0.7 #90234

merged 2 commits into from Jun 18, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Jun 13, 2020

Motivation for this change

Updated to latest release version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[root@nixos:~/nix/nixpkgs/pkgs/development/compilers/openjdk]# nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (0.03 MiB download, 0.13 MiB unpacked):
  /nix/store/j2gsdfiimrywkj0p5ir5cfs4q6ax068s-nixpkgs-review-2.3.1
copying path '/nix/store/j2gsdfiimrywkj0p5ir5cfs4q6ax068s-nixpkgs-review-2.3.1' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 48, done.
remote: Counting objects: 100% (48/48), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 60 (delta 42), reused 43 (delta 42), pack-reused 12
Unpacking objects: 100% (60/60), 19.57 KiB | 217.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
 * [new branch]              master     -> refs/nixpkgs-review/0
$ git worktree add /root/.cache/nixpkgs-review/rev-890485a2bd8ab4318048e24987d91986a4758ed3-dirty/nixpkgs 1d924f0354ffb255e79ec2274f8ab72640f93a60
Preparing worktree (detached HEAD 1d924f0354f)
Updating files: 100% (21856/21856), done.
HEAD is now at 1d924f0354f Merge pull request #89772 from rnhmjoj/dnschain
$ nix-env -f /root/.cache/nixpkgs-review/rev-890485a2bd8ab4318048e24987d91986a4758ed3-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
[nix-shell:~/nix/nixpkgs/pkgs/development/compilers/openjdk]# java -version
openjdk version "11.0.7-internal" 2020-04-14
OpenJDK Runtime Environment (build 11.0.7-internal+0-adhoc..jdk11u-jdk-11.0.7-ga)
OpenJDK 64-Bit Server VM (build 11.0.7-internal+0-adhoc..jdk11u-jdk-11.0.7-ga, mixed mode)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo June 13, 2020 12:05
@asbachb
Copy link
Contributor Author

asbachb commented Jun 17, 2020

/cc @jerith666 @lopsided98 @NeQuissimus

@flokli flokli merged commit ccaa301 into NixOS:master Jun 18, 2020
@flokli
Copy link
Contributor

flokli commented Jun 18, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asbachb @flokli @NeQuissimus