Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode, vscodium: add update.sh script #90224

Merged
merged 2 commits into from Jun 18, 2020
Merged

vscode, vscodium: add update.sh script #90224

merged 2 commits into from Jun 18, 2020

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jun 13, 2020 •
edited

Added simple bash script to automatically update versions and hashes for VSCode and VSCodium.

Originally discussed here: #90125

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kuznero kuznero self-assigned this Jun 13, 2020
@kuznero kuznero requested review from zowoq and Mic92 June 13, 2020 06:51
@kuznero kuznero mentioned this pull request Jun 13, 2020
Merged
10 tasks
@kuznero
Copy link
Member Author

kuznero commented Jun 14, 2020

This is ready to be merged, will break nothing.

@kuznero kuznero requested a review from zowoq June 18, 2020 07:26
@kuznero
Copy link
Member Author

kuznero commented Jun 18, 2020

It is ready to be merged in my mind.

@Mic92 Mic92 merged commit 977a349 into NixOS:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

Assignees

@kuznero kuznero

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuznero @zowoq @Mic92