Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kristall: init at 0.2 #90226

Merged
merged 1 commit into from Jun 16, 2020
Merged

kristall: init at 0.2 #90226

merged 1 commit into from Jun 16, 2020

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jun 13, 2020

Motivation for this change

Kristall is a browser without support for css/js/wasm or graphical websites. It can display user-styled documents in several formats, including gemini, html, markdown, … provided by a server via gemini, gopher, http, finger, …

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Thra11
Thra11 suggested changes Jun 13, 2020
View reviewed changes
Copy link
Member

@Thra11 Thra11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the fact that you should use the qt mkDerivation instead of stdenv.mkDerivation with wrapQtAppsHook, this is looking good to me.

pkgs/applications/networking/browsers/kristall/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/browsers/kristall/default.nix Outdated Show resolved Hide resolved
@ehmry ehmry requested a review from Thra11 June 13, 2020 14:54
Thra11
Thra11 approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@Thra11 Thra11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it and ran the result. Looks good to me.

@Thra11
Copy link
Member

Thra11 commented Jun 13, 2020

@ofborg eval

@ehmry ehmry merged commit f2592c0 into NixOS:master Jun 16, 2020
@ehmry ehmry deleted the kristall branch June 16, 2020 08:17
@fgaz
Copy link
Member

fgaz commented Jun 16, 2020

#85442 may also be of interest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thra11 Thra11 Thra11 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehmry @Thra11 @fgaz