Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq_8_12: init at 8.12+β1 #90227

Merged
merged 2 commits into from Jun 19, 2020
Merged

coq_8_12: init at 8.12+β1 #90227

merged 2 commits into from Jun 19, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 13, 2020

Motivation for this change

https://coq.github.io/doc/V8.12+beta1/refman/changes.html#version-8-12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Zimmi48
Zimmi48 reviewed Jun 16, 2020
View reviewed changes
pkgs/development/coq-modules/mathcomp/default.nix Outdated
@@ -76,7 +76,7 @@ let
};
# versions of coq compatible with released mathcomp versions
coq-versions = {
"1.11.0" = flip elem [ "8.7" "8.8" "8.9" "8.10" "8.11" ];
"1.11.0" = flip elem [ "8.7" "8.8" "8.9" "8.10" "8.11" "8.12" ];
"1.11+beta1" = flip elem [ "8.7" "8.8" "8.9" "8.10" "8.11" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that 1.11+beta1 is compatible with Coq 8.12 as well. But do you really want to keep this beta version in the list of available versions? We usually remove the beta versions of Coq for instance...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know and I didn’t check whether the β versions are compatible.

Maybe Cyril has an opinion about this. (ping @CohenCyril)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I didn't check in Nix, but I did check in Coq's v8.12 CI before 1.11.0 was released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve just added “8.12” to the “1.11+beta1” list.

Whether said list should be kept or not is a different topic, slightly independent from this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this change.

@ofborg ofborg bot requested a review from Zimmi48 June 17, 2020 08:33
@vbgl vbgl merged commit a8bb612 into NixOS:master Jun 19, 2020
@vbgl vbgl deleted the coq-8.12+β1 branch June 19, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenCyril CohenCyril CohenCyril approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@roconnor roconnor Awaiting requested review from roconnor

@Zimmi48 Zimmi48 Awaiting requested review from Zimmi48

Assignees
No one assigned
Labels
6.topic: coq 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @CohenCyril @Zimmi48