Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html5validator: init at 0.3.3 #90190

Merged
merged 1 commit into from Aug 23, 2020
Merged

html5validator: init at 0.3.3 #90190

merged 1 commit into from Aug 23, 2020

Conversation

phunehehe
Copy link
Contributor

Motivation for this change

Add new package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Jun 12, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cli tool only, please move it out of python-modules and python-packages.nix.

@phunehehe
Copy link
Contributor Author

@FRidh done

jonringer
jonringer reviewed Jun 12, 2020
View reviewed changes
pkgs/applications/misc/html5validator/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/html5validator/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/html5validator/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/html5validator/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the commits.

This can be done with:

git reset HEAD~<number_of_commits - 1>
git add -- pkgs/
git commit --amend --no-edit
git push ... ... --force

@ofborg ofborg bot removed the 6.topic: python label Jun 12, 2020
jonringer
jonringer reviewed Jun 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicks that I overlooked

pkgs/applications/misc/html5validator/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/html5validator/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/html5validator/default.nix Outdated Show resolved Hide resolved
@phunehehe
Copy link
Contributor Author

@jonringer suggestions applied

@phunehehe phunehehe requested a review from FRidh June 30, 2020 18:50
infinisil
infinisil approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review points have been addressed, this looks good!

@infinisil infinisil merged commit dc2b2bc into NixOS:master Aug 23, 2020
@phunehehe phunehehe deleted the html5validator branch August 23, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@infinisil infinisil infinisil approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phunehehe @jonringer @FRidh @infinisil