Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1b6e357424ea
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c8d064eec161
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 13, 2020

  1. gstreamer: Fix wrapper quoting 

    The bug was that the inner double quotes in "\$("…")" are not actually
inner like they would be in "$("…")".  We could write "\$(\"…\")", but
using single quotes on the outside makes everything simpler.

Fixes #63751.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    @andersk @FRidh
    andersk authored and FRidh committed Jun 13, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c8d064e View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 pkgs/development/libraries/gstreamer/core/default.nix
2 changes: 1 addition & 1 deletion pkgs/development/libraries/gstreamer/core/default.nix
View file
Original file line number Diff line number Diff line change
@@ -99,7 +99,7 @@ stdenv.mkDerivation rec {
postInstall = ''
for prog in "$dev/bin/"*; do
# We can't use --suffix here due to quoting so we craft the export command by hand
wrapProgram "$prog" --run "export GST_PLUGIN_SYSTEM_PATH=\$GST_PLUGIN_SYSTEM_PATH"$\{GST_PLUGIN_SYSTEM_PATH:+:\}"\$(unset _tmp; for profile in \$NIX_PROFILES; do _tmp="\$profile/lib/gstreamer-1.0''$\{_tmp:+:\}\$_tmp"; done; printf "\$_tmp")"
wrapProgram "$prog" --run 'export GST_PLUGIN_SYSTEM_PATH=$GST_PLUGIN_SYSTEM_PATH''${GST_PLUGIN_SYSTEM_PATH:+:}$(unset _tmp; for profile in $NIX_PROFILES; do _tmp="$profile/lib/gstreamer-1.0''${_tmp:+:}$_tmp"; done; printf '%s' "$_tmp")'
done
'';