Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

casperjs: remove #90212

Merged
merged 1 commit into from Jun 13, 2020
Merged

casperjs: remove #90212

merged 1 commit into from Jun 13, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

The package is abandoned upstream1 and no longer builds. Encountered while testing #90211 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samueldr samueldr merged commit c425454 into NixOS:master Jun 13, 2020
@lovesegfault lovesegfault deleted the rm-casper branch June 13, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

@jonringer jonringer jonringer approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@samueldr samueldr Awaiting requested review from samueldr

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @grahamc @jonringer @samueldr