Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.bravia-tv: 1.0.1 -> 1.0.5 #90171

Merged
merged 1 commit into from Jun 12, 2020
Merged

python3Packages.bravia-tv: 1.0.1 -> 1.0.5 #90171

merged 1 commit into from Jun 12, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Update bravia-tv to latest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

nixpkgs-review was good:

> nixpkgs-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 73, done.
remote: Counting objects: 100% (73/73), done.
remote: Total 126 (delta 73), reused 73 (delta 73), pack-reused 53
Receiving objects: 100% (126/126), 36.53 KiB | 667.00 KiB/s, done.
Resolving deltas: 100% (83/83), completed with 41 local objects.
From https://github.com/NixOS/nixpkgs
   9fbb82f46ef..dbdc5af9e81  master     -> refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-a267b8379116b24eca5d064cffc96b6ca6cfcd64/nixpkgs dbdc5af9e8145dbc7ffe71cf1c7287d7497f1c16
Preparing worktree (detached HEAD dbdc5af9e81)
Updating files: 100% (21848/21848), done.
HEAD is now at dbdc5af9e81 discord-canary: 0.0.103 -> 0.0.104
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-a267b8379116b24eca5d064cffc96b6ca6cfcd64/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit a267b8379116b24eca5d064cffc96b6ca6cfcd64
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-a267b8379116b24eca5d064cffc96b6ca6cfcd64/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages updated:
python37Packages.bravia-tv (1.0.1 → 1.0.5) python38Packages.bravia-tv (1.0.1 → 1.0.5)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-a267b8379116b24eca5d064cffc96b6ca6cfcd64/build.nix
[3 built, 36 copied (79.2 MiB), 14.2 MiB DL]
2 packages built:
python37Packages.bravia-tv python38Packages.bravia-tv

[0.0 MiB DL]
$ nix-shell /home/cole/.cache/nixpkgs-review/rev-a267b8379116b24eca5d064cffc96b6ca6cfcd64/shell.nix
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
  /nix/store/72ib72q10yzlgx2jdw2d2zq93l9dc4sg-bash-interactive-4.4-p23-dev
copying path '/nix/store/72ib72q10yzlgx2jdw2d2zq93l9dc4sg-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

[nix-shell:~/.cache/nixpkgs-review/rev-a267b8379116b24eca5d064cffc96b6ca6cfcd64]$

@colemickens colemickens marked this pull request as ready for review June 12, 2020 06:41
jonringer
jonringer approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 90171 1

2 packages built:
- python37Packages.bravia-tv
- python38Packages.bravia-tv

@jonringer jonringer merged commit 3d74684 into NixOS:master Jun 12, 2020
@colemickens colemickens deleted the rpi-bravia-tv branch December 30, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @jonringer