Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifiStable: 5.12.72 -> 5.13.29 #90173

Merged
merged 1 commit into from Jun 12, 2020
Merged

unifiStable: 5.12.72 -> 5.13.29 #90173

merged 1 commit into from Jun 12, 2020

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Jun 12, 2020 •
edited

Motivation for this change

Update unifi (unifiStable) to latest stable from Unifi.

See: https://community.ui.com/releases/UniFi-Network-Controller-5-13-29/d7647910-77a2-4e61-bbfe-389206f2d6ad

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

nixpkgs-review passed:

> nixpkgs-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-0693bed8eea074db1a052bbebe14e71b4994d774/nixpkgs dbdc5af9e8145dbc7ffe71cf1c7287d7497f1c16
Preparing worktree (detached HEAD dbdc5af9e81)
Updating files: 100% (21848/21848), done.
HEAD is now at dbdc5af9e81 discord-canary: 0.0.103 -> 0.0.104
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-0693bed8eea074db1a052bbebe14e71b4994d774/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 0693bed8eea074db1a052bbebe14e71b4994d774
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-0693bed8eea074db1a052bbebe14e71b4994d774/nixpkgs -qaP --xml --out-path --show-trace --meta
1 package updated:
unifi (5.12.72 → 5.13.29)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-0693bed8eea074db1a052bbebe14e71b4994d774/build.nix
[2 built, 1 copied (7.3 MiB), 1.3 MiB DL]
1 package built:
unifi

$ nix-shell /home/cole/.cache/nixpkgs-review/rev-0693bed8eea074db1a052bbebe14e71b4994d774/shell.nix

[nix-shell:~/.cache/nixpkgs-review/rev-0693bed8eea074db1a052bbebe14e71b4994d774]$

@ofborg ofborg bot requested review from erictapen and globin June 12, 2020 06:55
@marsam marsam merged commit 6e5952e into NixOS:master Jun 12, 2020
@colemickens colemickens deleted the rpi-unifi-stable branch December 30, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen Awaiting requested review from erictapen

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @marsam