Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broot: 0.13.6 -> 0.15.1 #90194

Merged
merged 1 commit into from Jun 13, 2020
Merged

broot: 0.13.6 -> 0.15.1 #90194

merged 1 commit into from Jun 13, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jun 12, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/1309his5ahkhf1yxphg6v460rkrjpwy3-broot-0.13.6 37.3M
/nix/store/snskszj1qicsd629fa0wbgm6ncnvc70l-broot-0.15.1 37.5M

@ofborg ofborg bot requested a review from magnetophon June 12, 2020 15:35
@bbigras
Copy link
Contributor Author

bbigras commented Jun 12, 2020

@GrahamcOfBorg build broot

@bbigras bbigras changed the title broot: 0.13.6 -> 0.15.0 broot: 0.13.6 -> 0.15.1 Jun 12, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Jun 12, 2020

@GrahamcOfBorg build broot

@marsam marsam merged commit 6be09e2 into NixOS:master Jun 13, 2020
@jonringer
Copy link
Contributor

i was about to merge this, lol

@marsam you beat me to it xD

@bbigras bbigras deleted the broot branch June 13, 2020 05:26
@bbigras
Copy link
Contributor Author

bbigras commented Jun 13, 2020

😆 Thank you both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetophon magnetophon Awaiting requested review from magnetophon

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @jonringer @marsam