Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{default,shell}.nix: don't use builtins.fetchGit #1371

Merged
merged 2 commits into from Jun 23, 2020
Merged

{default,shell}.nix: don't use builtins.fetchGit #1371

merged 2 commits into from Jun 23, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jun 13, 2020

Otherwise, this would prevent one from using import (fetchTarball "https://github.com/NixOS/nixops/archive/master.tar.gz") to run NixOps
from the master branch, for example. If you try to do so, you would see
some output like the following:

fatal: '/nix/store/nysvzmqi11zfchympbksb8wcb2dxw6yz-source' does not appear to be a git repository
fatal: Could not read from remote repository.

Fixes #1370.

Otherwise, this would prevent one from using `import (fetchTarball
"https://github.com/NixOS/nixops/archive/master.tar.gz")` to run NixOps
from the master branch, for example. If you try to do so, you would see
some output like the following:

    fatal: '/nix/store/nysvzmqi11zfchympbksb8wcb2dxw6yz-source' does not appear to be a git repository
    fatal: Could not read from remote repository.
@cole-h cole-h changed the title default.nix: don't use builtins.fetchGit {default,shell}.nix: don't use builtins.fetchGit Jun 17, 2020
@cole-h
Copy link
Member Author

cole-h commented Jun 17, 2020

This bumps flake-compat to include edolstra/flake-compat#4 (as well as support for versions 6 and 7 of the lockfile) -- now, builtins.fetchGit will be used automatically in the case that .git is present.

Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adisbladis I will push a PR on top of this one to update the pipeline, since we can now use a shallow repository.

@adisbladis adisbladis merged commit b743ad9 into NixOS:master Jun 23, 2020
@cole-h cole-h deleted the dont-use-fetchGit branch June 23, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use with fetchTarball after recent flakes migration due to builtins.fetchGit
3 participants