Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cde-gtk-theme: small adjustments #90221

Merged
merged 1 commit into from Jul 12, 2020
Merged

cde-gtk-theme: small adjustments #90221

merged 1 commit into from Jul 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2020 •
edited by ghost

Motivation for this change
  1. Don't build on Hydra, its just a packed theme
  2. Rename derivation from "cde-motif-theme" to "cdetheme", because theme folder name is "cdetheme", so there will be less confusion
    I.e. user need to set "cdetheme" in their gtkrc, so lets name the derivation the same
    [Settings]
    gtk-theme-name=cdetheme
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/186

@ghost ghost changed the title cdetheme: small adjustments cde-gtk-theme: small adjustments Jun 16, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/205

@ghost ghost requested review from romildo, NickHu and sauyon July 5, 2020 12:11
romildo
romildo approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/221

@romildo romildo merged commit bb834be into NixOS:master Jul 12, 2020
@ghost
Copy link
Author

ghost commented Jul 12, 2020

@romildo Thank you!

@ghost ghost deleted the cdetheme branch July 12, 2020 13:30
@ghost ghost removed request for NickHu and sauyon July 12, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nixos-discourse @romildo