Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyln-client: init at 0.8.0 #86882

Closed
wants to merge 3 commits into from

Conversation

zhenyavinogradov
Copy link
Contributor

@zhenyavinogradov zhenyavinogradov commented May 5, 2020

Motivation for this change

pyln-client is a client library for lightningd daemon: https://pypi.org/project/pyln-client/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kirelagin
Copy link
Member

This obsoletes #68311, since pylightning is now kinda deprecated (they don’t state this anywhere explicitly, but what is happening is they are breaking their Python bindings into better organised modules, and at this time pylightning is just a compatibility shim around pyln-client). Plugins are being switched to pyln-client instead of pylightning too.

@kirelagin
Copy link
Member

(Also, fwiw, works on macOS just fine.)


meta = with lib; {
description = "Client library for lightningd";
homepage = https://github.com/ElementsProject/lightning;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfc 45

Suggested change
homepage = https://github.com/ElementsProject/lightning;
homepage = "https://github.com/ElementsProject/lightning";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied

@@ -7328,6 +7328,8 @@ in {

rxv = callPackage ../development/python-modules/rxv { };

pyln-client = callPackage ../development/python-modules/pyln-client { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please attempt to order this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tried

@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@SuperSandro2000
Copy link
Member

@ofborg eval

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 7, 2022
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

Rebase and reopen if still interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants