Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.XMLRPCLite: init at 0.717 #86780

Merged
merged 1 commit into from Jun 10, 2020
Merged

perlPackages.XMLRPCLite: init at 0.717 #86780

merged 1 commit into from Jun 10, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Add missing cpan package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

stigtsp
stigtsp reviewed May 27, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build perlPackages.XMLRPCLite

stigtsp
stigtsp approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp requested a review from aanderse May 31, 2020 13:02
@aanderse
Copy link
Member

@GrahamcOfBorg build perldevelPackages.XMLRPCLite

@aanderse
Copy link
Member

See darwin log.

stigtsp
stigtsp requested changes May 31, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25-xmlrpc.t tries to connect to betty.userland.com:80 which on linux results in a skipped test, but this skip is not triggered on darwin. Since this test should be skipped in any case, I recommend removing it.

pkgs/top-level/perl-packages.nix Show resolved Hide resolved
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build perldevelPackages.XMLRPCLite

@aanderse
Copy link
Member

@GrahamcOfBorg build perldevelPackages.XMLRPCLite

@aanderse
Copy link
Member

Thanks team 🎉

@aanderse aanderse merged commit 15b098b into NixOS:master Jun 10, 2020
@sternenseemann sternenseemann deleted the xmlrpc-lite-0.7.17 branch September 29, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @aanderse @stigtsp