Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btrfs-heatmap: init at v8; incl. python.pkgs.btrfs #86861

Merged
merged 2 commits into from Jul 3, 2020
Merged

btrfs-heatmap: init at v8; incl. python.pkgs.btrfs #86861

merged 2 commits into from Jul 3, 2020

Conversation

evils
Copy link
Member

@evils evils commented May 5, 2020

Motivation for this change

pretty pictures
cruft

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • /nix/store/icvlas78f6xanwl8fv4fsf9g0932gm91-btrfs-heatmap-8-1 106812480
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils evils requested review from FRidh and jonringer as code owners May 5, 2020 00:43
@rardiol
Copy link
Contributor

rardiol commented May 5, 2020 •
edited

pretty pictures working for me.

edit: platforms could be set to linux as this apparently uses low level kernel calls that will only work on linux.

@evils evils changed the title btrfs-heatmap: init at v8-1; incl. pythonPackages.btrfs btrfs-heatmap: init at v8-1; incl. python.pkgs.btrfs Jun 28, 2020
@evils
Copy link
Member Author

evils commented Jun 28, 2020

/marvin opt-in
/status needs_review

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from timokau July 3, 2020 20:34
timokau
timokau requested changes Jul 3, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, just some small nitpicks.

pkgs/development/python-modules/btrfs/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/btrfs-heatmap/default.nix Outdated Show resolved Hide resolved
@evils evils mentioned this pull request Jul 3, 2020
Closed
@evils evils changed the title btrfs-heatmap: init at v8-1; incl. python.pkgs.btrfs btrfs-heatmap: init at v8; incl. python.pkgs.btrfs Jul 3, 2020
@evils
Copy link
Member Author

evils commented Jul 3, 2020

/status awaiting_reviewer

timokau
timokau approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me now, pending ofBorg (the manual status change should not have been necessary, will be fixed with timokau/marvin-mk2#36).

@timokau timokau merged commit e437a20 into NixOS:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evils @rardiol @timokau