Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] inkscape: 0.92.4 → 0.92.5 #86952

Closed
wants to merge 3 commits into from
Closed

[20.03] inkscape: 0.92.4 → 0.92.5 #86952

wants to merge 3 commits into from

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented May 5, 2020

Port of #85184 to 20.03. cc/ @jtojnar

Motivation for this change

Inkscape 0.92.4 depends on python 2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jtojnar May 5, 2020 15:38
@jtojnar
Copy link
Contributor

jtojnar commented May 5, 2020

I am not sure this is okay to backport. The update was minor only in version scheme. cc @worldofpeace

@prusnak prusnak added the 8.has: port to stable A PR already has a backport to the stable release. label May 11, 2020
@vbgl
Copy link
Contributor Author

vbgl commented May 12, 2020

How to know if this is OK to backport?

@jtojnar
Copy link
Contributor

jtojnar commented May 13, 2020

I think this is partly matter of opinion. We are not as strict as e.g. Ubuntu, for example we sometimes allow not-so-minor updates in leaf packages when they are broken (e.g. depend on an online service that changed API), but if the old it might be not worth the risk backporting – it might break users or even other packages.

Thankfully, I do not think this release includes the new CLI api that broke everything (#68930) but it still switched from Python 2 to Python 3. As such, it might be potentially breaking for users that have extra Inkscape extensions installed. For that reason, I think it is unsuitable for backporting into a stable release.

But maybe you can convince a release manager that the breakage is unlikely and the benefits are super neat.

@jtojnar @vbgl
inkscape: clean up
747af94 
The unpackPhase override was only needed when the download server mangled the file extension:

NixOS#23652
(cherry picked from commit 38e316d)
@jtojnar @vbgl
inkscape: format with nixpkgs-fmt
ecca5b1 
Also order the build inputs alphabetically and switch to pname+version.

(cherry picked from commit eff936e)
@jtojnar @vbgl
inkscape: 0.92.4 → 0.92.5
2a46312 
https://gitlab.com/inkscape/inkscape/-/tags/INKSCAPE_0_92_5
(cherry picked from commit a48d86e)
@vbgl
Copy link
Contributor Author

vbgl commented May 13, 2020

Thanks for the clarification.

@worldofpeace
Copy link
Contributor

I agree with @jtojnar this isn't suitable for backport, and just because in 20.03 we didn't axe python3 just yet.

@vbgl vbgl closed this Jun 18, 2020
@rissson rissson mentioned this pull request Jun 20, 2020
Merged
10 tasks
@vbgl vbgl deleted the inkscape-0.92.5 branch September 13, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @jtojnar @worldofpeace @prusnak