Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: remove decentral node-packages.json files #86776

Closed
wants to merge 7 commits into from
Closed

nodePackages: remove decentral node-packages.json files #86776

wants to merge 7 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 4, 2020 •
edited

Motivation for this change
  • reduce expression size of npm.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title nd nodePackages: remove decentral node-packages.json files May 4, 2020
@Mic92 Mic92 marked this pull request as ready for review May 4, 2020 13:44
@ofborg ofborg bot requested a review from michojel May 4, 2020 13:57
@Mic92 Mic92 force-pushed the node-refactorings branch 2 times, most recently from c0df3f7 to 538ffcd Compare May 9, 2020 14:26
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@oxalica oxalica mentioned this pull request Jan 9, 2021
Merged
10 tasks
@Mic92
Copy link
Member Author

Mic92 commented Jan 10, 2021

Maybe someone else can take this one further?

@Mic92 Mic92 closed this Jan 10, 2021
@Mic92 Mic92 deleted the node-refactorings branch July 23, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michojel michojel Awaiting requested review from michojel

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @prusnak @ryantm