Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11: fix vulkan icd filename #86834

Merged
merged 1 commit into from Nov 24, 2020
Merged

nvidia_x11: fix vulkan icd filename #86834

merged 1 commit into from Nov 24, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 4, 2020 •
edited

Haven't tested, which is why it's a draft right now.

Motivation for this change

Resolves #86620

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu
Copy link
Member Author

eadwu commented May 5, 2020 

❯  tree /nix/store/7gzpbpxx607s2avdxfmly880w1rqgifk-nvidia-x11-440.82-5.6.10/share/vulkan
/nix/store/7gzpbpxx607s2avdxfmly880w1rqgifk-nvidia-x11-440.82-5.6.10/share/vulkan
├── icd.d
│   └── nvidia_icd.x86_64.json
└── implicit_layer.d
    └── nvidia_layers.json

2 directories, 2 files

@eadwu eadwu marked this pull request as ready for review May 5, 2020 04:33
@eadwu eadwu force-pushed the nvidia_x11/fix-vulkan-icd branch from ce78e7f to cc4607a Compare May 5, 2020 17:04
@eadwu eadwu force-pushed the nvidia_x11/fix-vulkan-icd branch from cc4607a to eb5bf24 Compare May 23, 2020 15:39
@eadwu eadwu force-pushed the nvidia_x11/fix-vulkan-icd branch from eb5bf24 to a8c8218 Compare July 20, 2020 02:17
baracoder
baracoder approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@baracoder baracoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like mentioned here #86620 (comment) tools should not rely on filenames, therefore this change should not break anything, but then again this change should not be required.

@veprbl veprbl merged commit 7d9c1b2 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder baracoder approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nvidia_x11 uses non-standard ICD filename
3 participants
@eadwu @baracoder @veprbl