Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbill: install desktop file #86831

Merged
merged 1 commit into from Jan 18, 2021
Merged

xbill: install desktop file #86831

merged 1 commit into from Jan 18, 2021

Conversation

iblech
Copy link
Contributor

@iblech iblech commented May 4, 2020

Motivation for this change

Right now, xbill is missing from any graphical program menu because we don't ship the desktop file. This pull request fixes this issue. (I took the desktop file from Debian.)

Thank you, @aw, for your work maintaining this lovely oldie!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@herrwiese herrwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks!

@stale
Copy link

stale bot commented Nov 1, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 1, 2020
@herrwiese
Copy link
Contributor

Could somebody please merge this?

cc @worldofpeace @Mic92

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 4, 2020
@iblech
Copy link
Contributor Author

iblech commented Nov 10, 2020 via email

@iblech
Copy link
Contributor Author

iblech commented Jan 11, 2021

I finally got around to tending to this pull request. It now uses makeDesktopItem and copyDesktopItems. @worldofpeace, could you have a new look?

@ofborg ofborg bot requested a review from herrwiese January 11, 2021 16:29
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 86831 run on x86_64-linux 1

1 package built:
  • xbill

@SuperSandro2000 SuperSandro2000 merged commit 8f3a9c0 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants