Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: Don't symlink the $bin output #86830

Merged
merged 3 commits into from May 5, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 4, 2020

Motivation for this change

If we do it propagates and ends up in $PATH inside nix-shell

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member Author

@GrahamcOfBorg test podman

If we do it propagates and ends up in $PATH inside nix-shell
This seems brittle and fails on Hydra / OfBorg but not locally.
@zowoq
Copy link
Contributor

zowoq commented May 5, 2020

Changes look good but now the wrapper conflicts with staging-next.

@zowoq zowoq mentioned this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants