modules/filesystems/zfs: use current kernel #86835
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The derivation for zfs currently doesn't pull in the same kernel if
boot.kernel.randstructSeed
is set to a non-zero length string resulting in an extra kernel to build while also basically destroying the purpose of setting a randstructSeed, since the kernel used to build zfs would use a different seed.Using
callPackage
should also work sincekernel
won't be evaluated until the derivation is called, in which case the kernel would've been updated (I believe), but I'm not sure how that should be done without using a let/in block (which probably should be inall-packages.nix
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)[1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L16933