Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 5cf57c467987
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a17630204ac2
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 4, 2020

  1. fish: fix and enable fishConfig test 

    `nix-build -A fish.tests.fishConfig` will now test that the
`fish_config` tool would start up properly. Previously, this test was
effectively disabled due to `withTests` being stubbed out.

I don't think this test ever truly worked, because the generated
temporary file would be cleaned up automatically (or maybe this
"automatically" changed between versions). The solution to this is to
add `delete=False` to the `NamedTemporaryFile` function call, to keep
the temporary file around in order to grep its contents for the expected
output.
    @cole-h @Profpatsch
    cole-h authored and Profpatsch committed May 4, 2020
    Copy the full SHA
    a176302 View commit details
    Browse the repository at this point in the history