Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pantheon: mkDefault value for defaultSession #86908

Merged
merged 1 commit into from May 5, 2020
Merged

nixos/pantheon: mkDefault value for defaultSession #86908

merged 1 commit into from May 5, 2020

Conversation

jficz
Copy link
Contributor

@jficz jficz commented May 5, 2020 •
edited

Motivation for this change

Fixes #86907

Things done

Set defaultSession using mkDefault, not directly, to prevent conflicts.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@ofborg test pantheon

worldofpeace
worldofpeace suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change commit message to

nixos/pantheon: mkDefault value for defaultSession

Fixes #86907

@jficz jficz changed the title Make 'pantheon' a 'mkDefault' value for defaultSession nixos/pantheon: mkDefault value for defaultSession May 5, 2020
@jficz jficz requested a review from worldofpeace May 5, 2020 19:44
@worldofpeace worldofpeace merged commit 4ad2e1c into NixOS:master May 5, 2020
@worldofpeace
Copy link
Contributor

backported to 20.03 in 425aeec

@worldofpeace
Copy link
Contributor

Thanks for fixing this @cptMikky ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/pantheon: enabling Pantheon takes over defaultSession
2 participants
@jficz @worldofpeace