Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] openshot-qt: 2.4.4 -> 2.5.1 #86841

Merged
merged 3 commits into from May 5, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented May 4, 2020

Port of #83165 to 20.03.

Motivation for this change

openshot-qt is currently marked as broken

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @AndersonTorres

(cherry picked from commit ab7647b)
(cherry picked from commit 71ab434)
(cherry picked from commit 5f38229)
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

[4 built, 35 copied (248.7 MiB), 29.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86841
3 package built:
libsForQt5.libopenshot libsForQt5.libopenshot-audio openshot-qt

@jonringer jonringer merged commit e5cb3ef into NixOS:release-20.03 May 5, 2020
@vbgl vbgl deleted the openshot-qt-2.5.1 branch May 5, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants