Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superTuxKart: use assets directly from download #86842

Merged
merged 1 commit into from May 5, 2020
Merged

superTuxKart: use assets directly from download #86842

merged 1 commit into from May 5, 2020

Conversation

lheckemann
Copy link
Member

Motivation for this change

This saves copying the assets for each stk build, saving 600MiB each once more than one build is there with the same assets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann
superTuxKart: use assets directly from download
f62e2b2 
This saves ~600MiB per STK build, as long as the assets remain the same.
@ofborg ofborg bot requested review from peterhoeg and PyroLagus May 4, 2020 21:07
@peterhoeg peterhoeg merged commit d8cf475 into NixOS:master May 5, 2020
@lheckemann lheckemann deleted the supertuxkart-split-data branch May 5, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@PyroLagus PyroLagus Awaiting requested review from PyroLagus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lheckemann @peterhoeg