pythonPackages.powerline: Added fish binding #86874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
May 5, 2020
There was a problem hiding this comment.
please take a look at https://nixos.org/nixpkgs/manual/ under the installShellfiles section
Comment on lines
+41
to
+42
| install -dm755 "$out/share/fish/vendor_functions.d" | ||
| install -m644 "powerline/bindings/fish/powerline-setup.fish" "$out/share/fish/vendor_functions.d/powerline-setup.fish" |
There was a problem hiding this comment.
Suggested change
| install -dm755 "$out/share/fish/vendor_functions.d" | |
| install -m644 "powerline/bindings/fish/powerline-setup.fish" "$out/share/fish/vendor_functions.d/powerline-setup.fish" | |
| installShellCompletion powerline/bindings/fish/powerline-setup.fish |
... else where
nativeBuildInputs = [ installShellFiles ];
There was a problem hiding this comment.
I had seen that, however installShellCompletion can't be used in this case. The integration has to be installed to vendor_functions.d and not vendor_completions.d, as Powerline provides a function not a completion. I don't see any helper functions for installing functions.
justin-gerhardt
changed the title
|
@justin-gerhardt congrats on your first PR to nixpkgs! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding the fish shell integration
Should allow use by invoking the powerline-setup function from fish
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)