Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.toggl-cli: relax click version dependency #86921

Merged
merged 1 commit into from May 5, 2020
Merged

python3Packages.toggl-cli: relax click version dependency #86921

merged 1 commit into from May 5, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented May 5, 2020

fixes build problem by substituting click==7.0 with click>=7.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
python3Packages.toggl-cli: relax click version dependency
b693794 
fixes build problem by substituting click==7.0 with click>=7.0.
@ofborg ofborg bot requested a review from mmahut May 5, 2020 11:07
@Mic92
Copy link
Member

Mic92 commented May 5, 2020

Also opened a ticket for python3.8: AuHau/toggl-cli#138

@Mic92 Mic92 merged commit 40b89a0 into NixOS:master May 5, 2020
@Mic92
Copy link
Member

Mic92 commented May 24, 2020

Upstream said the next release will support python 3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @Mic92