Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vhd2vl: init #86807

Merged
merged 1 commit into from Aug 22, 2020
Merged

vhd2vl: init #86807

merged 1 commit into from Aug 22, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented May 4, 2020 •
edited

Motivation for this change

Adds vhd2vl, a vhdl to verilog converter.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

trepetti
trepetti approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@trepetti trepetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/205

danieldk
danieldk suggested changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small requested changes.

pkgs/applications/science/electronics/vhd2vl/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/vhd2vl/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/vhd2vl/default.nix Show resolved Hide resolved
@matthuszagh
Copy link
Contributor Author

Thanks for the review @danieldk! I've implemented the changes.

@danieldk danieldk merged commit 0d2d55f into NixOS:master Aug 22, 2020
@matthuszagh matthuszagh deleted the vhd2vl branch August 22, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@trepetti trepetti trepetti approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthuszagh @nixos-discourse @danieldk @trepetti