Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect non-ASCII paths as they confuse Mono #2549

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Apr 28, 2020

Will help users who run into #2548. Message:

The Principia DLL failed to load.
C:\Program Files\Kerbal Space Program\1.9.1- 多体 contains the non-ASCII character 多; this is known to confuse Mono.

Warning: don't load a Principia save before you have fixed this error; it might get damaged.

@eggrobin eggrobin added the LGTM label Apr 28, 2020
@pleroy pleroy merged commit 1f1ca24 into mockingbirdnest:master Apr 28, 2020
" contains the non-ASCII character " + c +
"; this is known to confuse Mono.";
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug could be Windows-only and is probably system-dependent (for instance, on recent versions of Windows, the code page can be 65001, in which case interpreting UTF-8 bytes in the current code page woould work).

Let’s flag this potential issue only if an error occurs, as we do with is_cxx_installed, instead of making it prevent us from even trying.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants