New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitkraken: 6.5.4 -> 6.6.0 #86893
gitkraken: 6.5.4 -> 6.6.0 #86893
Conversation
Builds locally with [nix-shell:~/.cache/nixpkgs-review/pr-86893]$ gitkraken
Gtk-Message: 11:50:24.612: Failed to load module "canberra-gtk-module"
Gtk-Message: 11:50:24.613: Failed to load module "canberra-gtk-module"
Error: libsecret-1.so.0: cannot open shared object file: No such file or directory
at process.func (electron/js2c/asar.js:140:31)
at process.func [as dlopen] (electron/js2c/asar.js:140:31)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:922:18)
at Object.func (electron/js2c/asar.js:140:31)
at Object.func [as .node] (electron/js2c/asar.js:149:18)
at Module.load (internal/modules/cjs/loader.js:735:32)
at Module._load (internal/modules/cjs/loader.js:648:12)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at Module.require (internal/modules/cjs/loader.js:775:19)
[nix-shell:~/.cache/nixpkgs-review/pr-86893]$ gitkraken --version
Gtk-Message: 11:50:33.861: Failed to load module "canberra-gtk-module"
Gtk-Message: 11:50:33.862: Failed to load module "canberra-gtk-module"
6.6.0 |
Looks like we might need to add a dep. I’ll take a look when I get a chance later today. Thanks for the stdout @drewrisinger! |
Interesting... no issues on my machine.... |
@drewrisinger what is the output of |
probably something with your configuration.nix is making it work. Only thing i could think of is dbus packages |
Note: ARTIQ full is https://nixbld.m-labs.hk/jobset/artiq/full |
Okay, so I think I misread this at first... After digging a little deeper, as things initially seem fine in ldd...
I have no idea what our GLIBC compatibility story looks like for older versions of NixOS, let alone older versions of other distros. At any rate, I was able to run this all just fine without these errors on a NixOS vm with an empty config + gitkraken + i3, so I don't think this is dependency-based, and seems to be related to Bionic Beaver using a different glibc, if I understand correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility with older non-NixOS distributions (due to different GLIBC versions?) aside, this looks good and seems to work fine for me.
Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gitkraken/versions.
meta.description for gitkraken is: "The downright luxurious and most popular Git client for Windows, Mac & Linux"
meta.homepage for gitkraken is: "https://www.gitkraken.com/"
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests
, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 6.6.0 with grep in /nix/store/ip7azp5lx4l7faqckw8s86vy9ri3p374-gitkraken-6.6.0
directory tree listing: https://gist.github.com/cf92d3889abb70e4a82c481e75d0bca4
du listing: https://gist.github.com/b5c29b84bdb9074cd3aea8356a6b1250
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
11 package built:
- gitkraken
Maintainer pings
cc @xNWDD @evanjs for testing.