Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vgo2nix: unstable-2019-02-05 -> unstable-2020-05-05 #86933

Merged
merged 1 commit into from May 5, 2020
Merged

vgo2nix: unstable-2019-02-05 -> unstable-2020-05-05 #86933

merged 1 commit into from May 5, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 5, 2020

Motivation for this change

This update includes some fixes that were merged in nix-community/vgo2nix#37 and are required to run the GitLab update script for recent versions of GitLab.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented May 5, 2020

Result of nixpkgs-review pr 86933 1

1 package built:
- vgo2nix

@ghost ghost mentioned this pull request May 5, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant