kloak: init at v0.2 #86824
kloak: init at v0.2 #86824
Conversation
| pname = "kloak"; | ||
| version = "v0.2"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
Use fetchFromGitHub instead.
|
|
||
| src = fetchgit { | ||
| url = "https://github.com/vmonaco/kloak.git"; | ||
| rev = "49ca7208f15b976b51df23666667f14c63a631d7"; |
There was a problem hiding this comment.
| rev = "49ca7208f15b976b51df23666667f14c63a631d7"; | |
| rev = "${version}"; |
|
Thanks for the review @mweinelt! I wasn't sure if the website-specific fetchers were preferred but I'm happy to defer to your judgement. |
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "kloak"; | ||
| version = "v0.2"; |
There was a problem hiding this comment.
Please move the v prefix into src.rev instead.
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Keystroke-level online anonymization kernel: obfuscates typing behavior at the device level"; | ||
| longDescription = "Note that this requires loading the 'uinput' kernel module."; |
There was a problem hiding this comment.
I'm not sure that is an appropriate use of the longDescription field.
There was a problem hiding this comment.
Perhaps not though I've seen basic usage notes in this field for other packages. Would a preferred alternative be a wrapper script to echo a warning if this kernel module is not loaded?
There was a problem hiding this comment.
I neither have a strong opinion nor much experience and would like to defer to someone else.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing as dead. |
stale
bot
removed
the
2.status: stale
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)