koreader: init at 2020.09 #86894
koreader: init at 2020.09 #86894
Conversation
ofborg
bot
added
8.has: package (new)
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
labels
|
Result of 1 package built:- koreader |
|
|
||
| sourceRoot = "."; | ||
| nativeBuildInputs = [ makeWrapper dpkg ]; | ||
| buildInputs = [ luajit gtk3-x11 SDL2 glib ]; |
There was a problem hiding this comment.
gtk3-x11 is just an alias of gtk3.
| dontBuild = true; | ||
|
|
||
| installPhase = '' | ||
| mkdir -p $out |
There was a problem hiding this comment.
When overriding installPhase, you should also provide runHook preInstall and runHook postInstall.
There was a problem hiding this comment.
I have pushed some updates. For now, please review it here. If that is desirable, I will make a new pr.
| wrapProgram $out/bin/koreader --prefix LD_LIBRARY_PATH : ${ | ||
| stdenv.lib.makeLibraryPath [ gtk3-x11 SDL2 glib ] | ||
| } |
There was a problem hiding this comment.
LD_LIBRARY_PATH can have side effects. Is autoPatchelfHook not sufficient?
There was a problem hiding this comment.
The reason to use LD_LIBRARY_PATH is because libSDL2-2.0.so.0 is loaded from the lua ffi api (i.e. the file https://github.com/koreader/koreader/blob/master/setupkoenv.lua), which is not a elf executable. I think I need to patch the file itself or inject LD_LIBRARY_PATH.
| description = | ||
| "An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Cervantes, Kindle, Kobo, PocketBook and Android devices"; | ||
| platforms = intersectLists platforms.x86_64 platforms.linux; | ||
| license = licenses.agpl3; |
There was a problem hiding this comment.
agpl3 is unclear, use agpl3Plus or agpl3Only. See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I am currently unable to build the binary from source code. Instead, I used the debian package upstream provided. I don't know what is the equivalent platforms for the upstream provide arm package. I only packaged the x86_64 version.