Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binutils: add avr-size patch #86812

Closed
wants to merge 1 commit into from
Closed

binutils: add avr-size patch #86812

wants to merge 1 commit into from

Conversation

FrozenDroid
Copy link

Motivation for this change

I was trying to work on an AVR project and I needed to determine the flash and RAM usage, so I tried to use --mcu and -C like I always had, but that didn't work. So I found out that avr-size was really just plain GNU binutils size, and missing this patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FrozenDroid
binutils: add avr-size patch
1e1f1e2 
To bring the avr-binutils package in line with other package managers
@FrozenDroid
Copy link
Author

Result of nixpkgs-review pr 86812 1

1 package failed to build:
- qmk_firmware
2 packages built:
- simavr
- tinygo

@FrozenDroid
Copy link
Author

According to https://hydra.nixos.org/build/118027403, qmk's firmware last successful build was a while ago. I don't think this change causes the compilation error.

bjornfor
bjornfor reviewed May 9, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the patch come from? Who is author? Can it be fetched instead of being committed to nixpkgs?

@FrozenDroid
Copy link
Author

We can maybe fetch the patch from Arch.
I found the patch here: https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/avr-binutils&id=afa8f7874658e824753a1f52c8ab5d03bbfa3745

@stale
Copy link

stale bot commented Nov 5, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 5, 2020
@SuperSandro2000
Copy link
Member

We can maybe fetch the patch from Arch.
I found the patch here: git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/avr-binutils&id=afa8f7874658e824753a1f52c8ab5d03bbfa3745

please fetch it from there.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@emilytrau
Copy link
Member

Closed by #197853 (oops should have searched better...)

@emilytrau emilytrau closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FrozenDroid @SuperSandro2000 @emilytrau @bjornfor @Janik-Haag