Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frozen-bubble: install desktop file #86914

Closed
wants to merge 1 commit into from
Closed

frozen-bubble: install desktop file #86914

wants to merge 1 commit into from

Conversation

iblech
Copy link
Contributor

@iblech iblech commented May 5, 2020

Motivation for this change

Thank you, @puckipedia, for maintaining Frozen Bubble in nixpkgs! This pull request just adds a desktop file (lifted from Debian) together with appropriate icons (which are already part of the upstream package).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

puckipedia
puckipedia suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@puckipedia puckipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I use a DE without desktop entry support, so I missed this in my time porting it. There's two small issues I'd like to see resolved before approving, see comments.

pkgs/games/frozen-bubble/default.nix Outdated Show resolved Hide resolved
pkgs/games/frozen-bubble/default.nix Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Nov 1, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 1, 2020
@SuperSandro2000
Copy link
Member

@iblech friendly ping

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 25, 2020
@iblech
Copy link
Contributor Author

iblech commented Nov 26, 2020

Thank you @SuperSandro2000 for the friendly ping, and thank you @puckipedia and @teto for your reviews! Very much appreciated. I don't have time to incorporate your suggestions in the next couple of days, but want to do so soon. If you want to beat me to it, then feel free, but no worries, else I'll do it :-)

@iblech
Copy link
Contributor Author

iblech commented Jan 11, 2021

@SuperSandro2000 I finally got around to this -- I believe this pull request can be merged now. :-)

@iblech iblech force-pushed the patch-17 branch 2 times, most recently from a85e98d to db28ff0 Compare January 11, 2021 15:33
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 86914 run on x86_64-linux 1

1 package built:
  • frozen-bubble

@iblech
Copy link
Contributor Author

iblech commented Feb 14, 2021

I'm closing this because I just noticed that @khumba has pushed a commit with the same effect :-)

@iblech iblech closed this Feb 14, 2021
@khumba
Copy link
Contributor

khumba commented Feb 15, 2021

Hi @iblech, I'm sorry I didn't search and see this PR before I opened mine! This one is better, it would be nice to have the icons too. I'll do a proper search and not just check master next time.

@iblech
Copy link
Contributor Author

iblech commented Feb 15, 2021

@khumba Absolutely no worries, I'm happy that we now have the desktop file. In the past I also overlooked already existing pull requests. It's bound to happen with 2.4k open :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@puckipedia puckipedia puckipedia requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iblech @SuperSandro2000 @khumba @puckipedia @teto