Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish-fillets-ng: install desktop file #86912

Merged
merged 2 commits into from Jan 14, 2021
Merged

fish-fillets-ng: install desktop file #86912

merged 2 commits into from Jan 14, 2021

Conversation

iblech
Copy link
Contributor

@iblech iblech commented May 5, 2020

Motivation for this change

Thank you, @raskin, for your work maintaining this game in nixpkgs!

This pull requests adds the desktop file (lifted from Debian) so that the game is easily reachable from graphical menus.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c May 5, 2020 09:17
@stale
Copy link

stale bot commented Nov 3, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 3, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 25, 2020
@doronbehar
Copy link
Contributor

I'm closing as op is not responsive.

@doronbehar doronbehar closed this Dec 25, 2020
@iblech
Copy link
Contributor Author

iblech commented Dec 26, 2020

Sorry for being not responsive! I will implement the changes suggested by the review in the next couple of days and then reopen this pull request. :-)

@iblech iblech reopened this Jan 11, 2021
@iblech iblech force-pushed the patch-15 branch 2 times, most recently from 4ece4bd to 289c46d Compare January 11, 2021 15:58
@iblech
Copy link
Contributor Author

iblech commented Jan 11, 2021

@doronbehar I finally got around to tending to this pull request and believe that it can now be merged. Could you have a new look?

@ofborg ofborg bot requested a review from 7c6f434c January 11, 2021 17:20
SuperSandro2000
SuperSandro2000 reviewed Jan 12, 2021
View reviewed changes
pkgs/games/fish-fillets-ng/default.nix Outdated Show resolved Hide resolved
pkgs/games/fish-fillets-ng/default.nix Outdated Show resolved Hide resolved
pkgs/games/fish-fillets-ng/default.nix Outdated Show resolved Hide resolved
@iblech
Copy link
Contributor Author

iblech commented Jan 12, 2021

Thank you @SuperSandro2000 for your review, I believe I fixed all issues you mentioned. :-)

SuperSandro2000
SuperSandro2000 approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that diff LGTM

pkgs/games/fish-fillets-ng/default.nix Outdated Show resolved Hide resolved
pkgs/games/fish-fillets-ng/default.nix Outdated Show resolved Hide resolved
@iblech
Copy link
Contributor Author

iblech commented Jan 13, 2021

Fixed according to diff. :-)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 86912 run on x86_64-linux 1

1 package built:
  • fish-fillets-ng

@7c6f434c 7c6f434c merged commit 195c3ac into NixOS:master Jan 14, 2021
@iblech
Copy link
Contributor Author

iblech commented Jan 14, 2021

Awesome, thank you both, @SuperSandro2000 and @7c6f434c for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iblech @doronbehar @SuperSandro2000 @7c6f434c