Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minc-tools: actually build Nifti support #91071

Merged
merged 1 commit into from Jul 6, 2020
Merged

minc-tools: actually build Nifti support #91071

merged 1 commit into from Jul 6, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jun 18, 2020 •
edited

Due to a couple of packaging issues, Nifti support wasn't enabled. (One may confirm that programs such as nii2mnc and mnc2nii are newly being built.)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

bcdarwin commented Jun 18, 2020 •
edited

@GrahamcOfBorg build minc_tools

@bcdarwin bcdarwin force-pushed the minc-tools-build-nifti-tools branch from 2a08b11 to 28becad Compare July 6, 2020 15:10
@bcdarwin bcdarwin requested a review from bhipple July 6, 2020 15:13
@bhipple
Copy link
Contributor

bhipple commented Jul 6, 2020

Result of nixpkgs-review pr 91071 1

3 packages built:
- conglomerate
- minc_tools
- minc_widgets

@bhipple bhipple merged commit 0f94e24 into NixOS:master Jul 6, 2020
@bcdarwin bcdarwin deleted the minc-tools-build-nifti-tools branch July 7, 2020 16:43
@bcdarwin bcdarwin mentioned this pull request Sep 22, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @bhipple