Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: 2.18.1 -> 2.19.1 #91100

Merged
merged 1 commit into from Jun 19, 2020
Merged

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Jun 19, 2020

Motivation for this change

https://github.com/prometheus/prometheus/releases/tag/v2.19.0
https://github.com/prometheus/prometheus/releases/tag/v2.19.1

Things done

I updated an existing prometheus installation and had a quick look at grafana and the new prometheus react ui.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alyssais alyssais merged commit 674b914 into NixOS:master Jun 19, 2020
@priegger priegger deleted the fix/prometheus-update branch June 22, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants