Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Unbreak zconfig and zodb #91099

Merged
merged 2 commits into from Jul 3, 2020
Merged

[20.03] Unbreak zconfig and zodb #91099

merged 2 commits into from Jul 3, 2020

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

Fixing vulnix.

I'm not sure if this is the correct patch, or whether I should disable the package for isPy27. It's not that those packages will build for Python 2 because manuel requires Python 3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 19, 2020

if it does not build for a python version, then disable it for that version

@KamilaBorowska
Copy link
Member Author 

$ nix-build -A pythonPackages.zodb
error: manuel-1.10.1 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)

Okay, so I guess I should explicitly disable zodb too?

@ckauhaus
Copy link
Contributor

ckauhaus commented Jul 3, 2020

@xfix probably add a disable attribute for Python 2.

@Mic92
Copy link
Member

Mic92 commented Jul 3, 2020 

$ nix-build -A pythonPackages.zodb
error: manuel-1.10.1 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)

Okay, so I guess I should explicitly disable zodb too?

It is not strictly required if the dependencies are already disabled for python2 IMHO.

@ckauhaus ckauhaus merged commit d6260a3 into NixOS:release-20.03 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @FRidh @ckauhaus @Mic92