Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tanka: init at 0.10.0 #90724

Closed
wants to merge 1 commit into from
Closed

tanka: init at 0.10.0 #90724

wants to merge 1 commit into from

Conversation

Konubinix
Copy link

@Konubinix Konubinix commented Jun 18, 2020

I am very new to nix. I assumed a good way to start and learn was by contributing adding a new package.

Motivation for this change

I want to use tanka and it was not in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions -> debian testing
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NickHu
Copy link
Contributor

NickHu commented Jun 18, 2020

Thanks for your contribution! Please make sure to read https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md; it's really not long! In particular, your commit and the title of this pull request should be formatted like:

tanka: init at 0.10.0

The other thing is I'm not sure it's such a good idea to lock all the dependencies, but maybe that's for someone more familiar with Go to decide. Does the package not build if you exclude them?

@Konubinix Konubinix changed the title Add tanka tanka: init at 0.10.0 Jun 18, 2020
@Konubinix
Copy link
Author

Thank you for your feedback. I read the contributing guidelines and modified the commit accordingly :-).

It says the package must have a maintainer. Is not having a maintainer a no go for pushing tanka in nixpkgs?

About the dependencies, I used the output of vgo2nix without thinking much. I understand your point and will fix the commit by adding only the explicit dependencies. I am not familiar with Go either but looking at the generated deps.nix in nixpkgs, it appears that they indeed don't include dependencies of dependencies.

Thank you again for your time.

@Konubinix
Copy link
Author

I realize you have a lot of pull requests. For I will finally not use tanka, I will close this one to avoid any additional entropy.

Thank you anyway for taking the time to answer me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants