Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt: 3000.3 -> 3001 #91066

Merged
merged 1 commit into from Jul 6, 2020
Merged

salt: 3000.3 -> 3001 #91066

merged 1 commit into from Jul 6, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Jun 18, 2020

Motivation for this change

Version 3001 was released: https://docs.saltstack.com/en/latest/topics/releases/3001.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

This looks good to me, thanks.

Result of nixpkgs-review pr 91066 1

1 package built:
- salt

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/176

@mweinelt mweinelt merged commit 2ca9cbc into NixOS:master Jul 6, 2020
@mweinelt
Copy link
Member

mweinelt commented Jul 6, 2020

Thanks, merged.

@Flakebi Flakebi deleted the salt branch July 6, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants