Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate and sort font-variation-settings when computing style. #24246

Merged
merged 1 commit into from Jul 9, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 19, 2020

Make interpolation type always run CSSValues through the converter for
this property.

Update remaining WPT tests to use order-invariant comparison (as most
tests for this property already use).

spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def

If the same axis name appears more than once, the value associated with
the last appearance supersedes any previous value for that axis. This
deduplication is observable by accessing the computed value of this
property.

resolution w3c/csswg-drafts#1959
RESOLVED: For both font-variation-settings and font-feature-settings,
the computed value is a map (and thus specified dupes are removed)

Bug: 1005355
Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786564}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title deduplicate and sort font-variation-settings when computing style. Deduplicate and sort font-variation-settings when computing style. Jun 23, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2253248 branch 5 times, most recently from 12d6ea8 to 7815cd3 Compare June 26, 2020 00:56
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2253248 branch 2 times, most recently from bc86672 to 398ee8a Compare July 8, 2020 19:40
Make interpolation type always run CSSValues through the converter for
this property.

Update remaining WPT tests to use order-invariant comparison (as most
tests for this property already use).

spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def

If the same axis name appears more than once, the value associated with
the last appearance supersedes any previous value for that axis. This
deduplication is observable by accessing the computed value of this
property.

resolution w3c/csswg-drafts#1959
RESOLVED: For both font-variation-settings and font-feature-settings,
the computed value is a map (and thus specified dupes are removed)

Bug: 1005355
Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786564}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants